[Code] cancel source view page outdated request #43348
Conversation
WangQianliang
added
v8.0.0
Team:Code
release_note:skip
|
Pinging @elastic/code |
💔 Build Failed |
| abortController.abort(); | ||
| } | ||
|
|
||
| export const cancellableSaga = (saga: any) => |
There was a problem hiding this comment.
nit: this sounds more like a singleton saga, instead of a cancellable saga. After all, every saga is always cancellable by itself. 😀
|
|
||
| export const cancellableSaga = (saga: any) => | ||
| function*(action: Action<any>) { | ||
| const abortController = new AbortController(); |
There was a problem hiding this comment.
Correct me if I'm wrong. Is this abortController created every time? Shouldn't we cancel the one last created when the request is sent?
There was a problem hiding this comment.
My understanding here is the next action with the same type will trigger the abort() (line 12) of a previous created abortController. Then thus signal via line 19. So essentially this code block is just hooking up all the cancellation logic, which the actual cancellation is triggered until the next action with the same type is detected. It does take a moment to understand the code here. @WangQianliang if you reference any stackoverflow answer, please comment here.
There was a problem hiding this comment.
Yes, it's created every time to detect if there's new action dispatched so that it will cancel this request. In my latest commit, it would cancel the abort request task if api request succeeds or fails.
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
…_update_json_spec * 'master' of github.com:elastic/kibana: (35 commits) fix: 🐛 pass whole action context to isCompatible() method (elastic#43457) Deleted old kbn-top-nav directive (elastic#43168) [ML] Fixing cloning of single metric distinct count job (elastic#43435) Update @elastic/charts version 8.1.6 > 9.1.1 (elastic#43516) [Inspector Views] [Request View] - Migrate inspector_views to new platform (elastic#43191) [ML] Adding loading indicators to all wizard charts (elastic#43382) disable flaky test (elastic#43492) feature(code/frontend): cancel file blob and directory commits request if outdated (elastic#43348) fix(code/frontend): button group url should have previous query string (elastic#43428) [SIEM] Fixes index substring incorrectly matching configured indices and failing to install ML job (elastic#43409) [SIEM] Adds performance enhancements such by removing wasted renderers and adding incremental DOM rendering (elastic#43157) disable flaky test (elastic#37859) Added sass lint to Canvas (elastic#43410) [Maps] add indicator when layer is filtered by search bar (elastic#43283) Properly validate current user password during password change. (elastic#43447) Spaces - allow for hex color codes that include uppercase characters (elastic#43470) [Reporting] Add a bit more logging and a few more logging level promotions (elastic#43415) Partially convert index pattern server to typescript (elastic#43291) [Infra UI] Use sum for aggregating AWS metrics. (elastic#43293) [SIEM] Format bytes columns in timeline (elastic#43147) ...
Summary
cancel file blob and directory commits request if outdated
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately